Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration #2

Merged
merged 11 commits into from
Aug 18, 2021
Merged

Migration #2

merged 11 commits into from
Aug 18, 2021

Conversation

Citrullin
Copy link

Based on commit e2413bc

Copy link
Owner

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #1 asked for small changes. Mostly about commented code... can I ask you to fix those before merging on dev branch?

@relu91 relu91 changed the base branch from master to dev August 13, 2021 16:51
@Citrullin
Copy link
Author

In #1 asked for small changes. Mostly about commented code... can I ask you to fix those before merging on dev branch?

Will do. No problem.

@Citrullin
Copy link
Author

@relu91 Addressed all of your mentioned issues. Can you take a look at it?

Copy link
Owner

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!, just a minor point below, and then it's ready to go.

WiFi101WebThingAdapter.h Show resolved Hide resolved
@Citrullin Citrullin changed the title WIP: Migration Migration Aug 17, 2021
@relu91 relu91 merged commit 1e1d8d7 into relu91:dev Aug 18, 2021
@relu91 relu91 mentioned this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants